Repository navigation
feat(tui): show the stats back shortcut - #53658
Open
maharshi365 wants to merge 4 commits into
Open
maharshi365 wants to merge 4 commits into
maharshi365 wants to merge 4 commits into
Conversation
Show a clickable esc back footer outside the stats scroll area so users can discover how to return to their previous screen. Keep it available during loading, success, and error states. Update the stats view regression test to require the back hint on loaded and error screens while preserving Escape navigation coverage. Refs anomalyco#53657
Match the home footer spacing with a blank bottom row. Let the stats scroll area shrink so its content cannot displace the back control below the screen. Verify bottom-right placement at narrow and wide terminal sizes and exercise click-to-return alongside the existing Escape navigation check.
github-actions
Bot
added
contributor
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Remove the mouse handler and use muted text for the Escape shortcut hint. Restore keyboard navigation in the success-state regression test while keeping visibility and placement coverage.
maharshi365
changed the title
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Update the PR branch with upstream v2 while retaining only the stats shortcut hint and its regression coverage as the PR changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #53657
Type of change
What does this PR do?
Adds an
esc backshortcut hint to/stats. Escape already returns to the previous screen, but nothing on the page tells users that.The hint is not clickable. It sits below the scroll area with the home footer's right and bottom spacing. Setting
minHeight={0}on the scroll area keeps it from pushing the hint off-screen in short terminals.How did you verify your code works?
packages/tui:bun test test/stats.view.test.tsx --timeout 30000andbun typecheckpassed.bun run checkpassed through the pre-push hook, with existing lint warnings.Screenshots / recordings
Stats screen showing the new hint at the bottom-right:
Checklist